Skip to content

Refactor package structure for LoggedUserConfiguration#441

Merged
machacjozef merged 1 commit into
release/7.0.0-rev10from
fix/user_factory_config
May 21, 2026
Merged

Refactor package structure for LoggedUserConfiguration#441
machacjozef merged 1 commit into
release/7.0.0-rev10from
fix/user_factory_config

Conversation

@renczesstefan
Copy link
Copy Markdown
Member

@renczesstefan renczesstefan commented May 21, 2026 •
edited by coderabbitai Bot
Loading

Description

Replacing user factory configuration to make it available for core adapter library.

Dependencies

No new dependencies were introduced.

Third party dependencies

No new dependencies were introduced.

Blocking Pull requests

There are no dependencies on other PR.

How Has Been This Tested?

This was tested manually and with unit tests.

Test Configuration

Name Tested on
OS macOS Tahoe 26.3
Runtime Java 21
Dependency Manager Maven 3.9.9n
Framework version Spring Boot 3.4.4
Run parameters
Other configuration

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes have been checked, personally or remotely, with @machacjozef
  • I have commented my code, particularly in hard-to-understand areas
  • I have resolved all conflicts with the target branch of the PR
  • I have updated and synced my code with the target branch
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes:
    • Lint test
    • Unit tests
    • Integration tests
  • I have checked my contribution with code analysis tools:
  • I have made corresponding changes to the documentation:
    • Developer documentation
    • User Guides
    • Migration Guides

Summary by CodeRabbit

  • Refactor
    • Reorganized internal authentication configuration components to improve code structure and maintainability.
    • Simplified implementation logic for enhanced code efficiency.

Review Change Stack

@renczesstefan
Refactor package structure for LoggedUserConfiguration and DefaultLog…
8420cf6 
…gedUserFactory

Moved classes to the `adapter.spring` package for better modularity and alignment with the Spring adapter layer. Simplified object creation in `DefaultLoggedUserFactory#create`.
@renczesstefan renczesstefan self-assigned this May 21, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 21, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 2c491b56-92c3-45dc-b74e-692f4ca0883e

📥 Commits

Reviewing files that changed from the base of the PR and between eadd2f3 and 8420cf6.

📒 Files selected for processing (2)
  • nae-spring-core-adapter/src/main/java/com/netgrif/application/engine/adapter/spring/auth/service/DefaultLoggedUserFactory.java
  • nae-spring-core-adapter/src/main/java/com/netgrif/application/engine/adapter/spring/configuration/LoggedUserConfiguration.java

Walkthrough

DefaultLoggedUserFactory relocates from core to adapter-specific packages and simplifies its create() method. LoggedUserConfiguration similarly moves to the adapter-specific package and updates its import to reference the relocated factory.

Changes

Logged user factory package restructuring

Layer / File(s) Summary
Move DefaultLoggedUserFactory to adapter package and simplify
nae-spring-core-adapter/src/main/java/com/netgrif/application/engine/adapter/spring/auth/service/DefaultLoggedUserFactory.java		 DefaultLoggedUserFactory relocates to com.netgrif.application.engine.adapter.spring.auth.service and its create() method is simplified to return new LoggedUserImpl() directly.
Update LoggedUserConfiguration package and imports
nae-spring-core-adapter/src/main/java/com/netgrif/application/engine/adapter/spring/configuration/LoggedUserConfiguration.java		 LoggedUserConfiguration moves to com.netgrif.application.engine.adapter.spring.configuration and updates the DefaultLoggedUserFactory import to reference the relocated adapter-side class.

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change: moving LoggedUserConfiguration and DefaultLoggedUserFactory classes to align with the Spring adapter package structure.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@machacjozef machacjozef merged commit eb098e1 into release/7.0.0-rev10 May 21, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@machacjozef machacjozef machacjozef approved these changes

@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes

@Retoocs Retoocs Awaiting requested review from Retoocs

@tuplle tuplle Awaiting requested review from tuplle

Assignees

@renczesstefan renczesstefan

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@renczesstefan @machacjozef